Re: [PATCH] Issue 3227 - adding some extra "custom" headers to the email

On Thu, Jan 22, 2009 at 11:03, Jon Bendtsen <jbendtsen_at_laerdal.dk> wrote:
>...
> But what if people wants more than module, branch, submodule and file.
> What about directory and subdir, ...
>
> Maybe we should add generic fields like
> pf1, pf2, ... (Path Field 1, 2, ...)

That is what I've been trying to describe. You can name each of the
fields as corresponding to a particular path segment:

headers_from_path = module/branch/submodule/directory/subdir/.../file

>>>> Because you defined the superclass to take that parameter. The
>>>> MailedOutput.start() call is going to throw an exception because you
>>>> don't pass the value.
>>>
>>> I didnt experience exceptions or other faults on the ~25.000 changes
>>> we had in our subversion repository. I started the script by "hand"
>>> to
>>> a dummy email address, and there was nothing on stdout or stderr.
>>
>> The exception would be raised if you use the smtp_hostname
>> configuration option. I suspect you maybe used the mail_command
>> configuration instead? Or maybe left both blank and generated to
>> stdout instead?
>
> i use mail_command. I can try using the smtp_hostname

No need to try it. I know it will throw an exception. Just add that
parameter like I pointed out, and it should work fine.

>...

Cheers,
-g

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1043014
Received on 2009-01-22 11:30:50 CET