[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: segfault in 'svn up' on trunk

From: Bert Huijben <rhuijben_at_sharpsvn.net>
Date: Wed, 21 Jan 2009 23:11:59 +0100

> -----Original Message-----
> From: Stefan Sperling [mailto:stsp_at_elego.de]
> Sent: Wednesday, January 21, 2009 11:06 PM
> To: Greg Stein
> Cc: Hyrum K. Wright; dev_at_subversion.tigris.org
> Subject: Re: segfault in 'svn up' on trunk
>
> On Wed, Jan 21, 2009 at 04:02:54PM +0100, Greg Stein wrote:
> > 0x69737265 looks like ascii characters: i s r e
> >
> > Somehow the path pointer is getting munged by some text?
>
> We need to audit that code more.

Note that this was just a dangling pointer in a svn_wc_notify_t structure
that wasn't initialized with apr_pcalloc as I expected, but with apr_palloc.
See r35366.

So please do review the dirent api (as it it a big TODO for 1.6), but not
for this specific bug.

        Bert

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1042215
Received on 2009-01-22 09:03:18 CET

This is an archived mail posted to the Subversion Dev mailing list.