Re: segfault in 'svn up' on trunk

On Wed, Jan 21, 2009 at 11:11:59PM +0100, Bert Huijben wrote:
>
>
> > -----Original Message-----
> > From: Stefan Sperling [mailto:stsp_at_elego.de]
> > Sent: Wednesday, January 21, 2009 11:06 PM
> > To: Greg Stein
> > Cc: Hyrum K. Wright; dev_at_subversion.tigris.org
> > Subject: Re: segfault in 'svn up' on trunk
> >
> > On Wed, Jan 21, 2009 at 04:02:54PM +0100, Greg Stein wrote:
> > > 0x69737265 looks like ascii characters: i s r e
> > >
> > > Somehow the path pointer is getting munged by some text?
> >
> > We need to audit that code more.
>
> Note that this was just a dangling pointer in a svn_wc_notify_t structure
> that wasn't initialized with apr_pcalloc as I expected, but with apr_palloc.
> See r35366.

Thanks!

Maybe we should also do an apr_palloc -> apr_pcalloc sweep?

I.e. make sure all allocations we do will result in properly
initialised values (be it by using apr_pcalloc or initialising
allocated memory by other means)? A lot of our code seems to
assume that memory is always initalised (and why shouldn't it?).

This problem has happened a few times already. At least I remember
a few patches and commits by Stefan Küng that fixed similar problems.

Stefan
Received on 2009-01-21 23:29:37 CET