[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [RFC] New indented propget/proplist output needs a tweak for v1.6

From: Paul Burba <ptburba_at_gmail.com>
Date: Tue, 20 Jan 2009 09:28:09 -0500

On Tue, Jan 20, 2009 at 8:43 AM, C. Michael Pilato <cmpilato_at_collab.net> wrote:
> Julian Foad wrote:
>> I think I need to tweak the new indented "svn propget" output format.
>>
>>
>> BACKGROUND
>> ==========
>>
>> Some time back (r32484) I changed the output format of "svn proplist -v"
>> to indent every line of a multi-line property value, to make it
>> parseable and more readable:
>>
>> In v1.5:
>> [[[
>> $ svn-1.5.4 proplist -v subversion/tests/cmdline/
>> Properties on 'subversion/tests/cmdline':
>> svn:ignore : svn-test-work
>> httpd-*
>> .gdb_history
>> *.pyc
>> ...
>> ]]]
>>
>> In trunk:
>> [[[
>> $ svn proplist -v subversion/tests/cmdline/
>> Properties on 'subversion/tests/cmdline':
>> svn:ignore
>> svn-test-work
>> httpd-*
>> .gdb_history
>> *.pyc
>> ...
>> ]]]
>>
>> For "svn propget", I made a similar change, but a little differently. In
>> comparison to v1.5, the new format always shows the file name, always
>> shows the property name, and indents the value, but I chose to make this
>> new format happen only with "-v/--verbose", feeling that tools might be
>> more commonly parsing the output (at least when it is parseable, such as
>> when requesting just one property from one target). The command did not
>> use "-v" before.
>>
>> In v1.5, and also in trunk without "-v":
>> [[[
>> $ svn-1.5.4 propget svn:ignore subversion/tests/cmdline/
>> svn-test-work
>> httpd-*
>> .gdb_history
>> *.pyc
>> ...
>>
>> $ svn-1.5.4 propget -R svn:ignore subversion/tests/cmdline/
>> subversion/tests/cmdline/svntest - *.pyc
>> *.o
>> ...
>> subversion/tests/cmdline - svn-test-work
>> httpd-*
>> .gdb_history
>> *.pyc
>> ...
>> ]]]
>>
>> In trunk:
>> [[[
>> $ svn propget -v svn:ignore subversion/tests/cmdline/
>> Properties on 'subversion/tests/cmdline':
>> svn:ignore
>> svn-test-work
>> httpd-*
>> .gdb_history
>> *.pyc
>> ...
>>
>> $ svn propget -vR svn:ignore subversion/tests/cmdline/
>> Properties on 'subversion/tests/cmdline/svntest':
>> svn:ignore
>> *.pyc
>> *.o
>> ...
>> Properties on 'subversion/tests/cmdline':
>> svn:ignore
>> svn-test-work
>> httpd-*
>> .gdb_history
>> *.pyc
>> ...
>> ]]]
>>
>> The benefit is seen better with recursive or longer listings, especially
>> with long values like svn:mergeinfo and svn:ignore. (For properties with
>> short names and short single-line values, the old format looks nicer for
>> some purposes.)
>>
>>
>> NOW...
>> ======
>>
>> I don't like using "-v" to change propget's output format, and part of
>> the reason I left it like that is so we can get a feel for which we
>> prefer.
>>
>> I think we should:
>>
>> A. Make "propget" print just the plain value with no header when there
>> is only one target, like it used to, but use the new indented format
>> when there are multiple targets. Remove the new use of "-v". (Leave
>> "proplist" as it
>
> Do you mean "multiple targets" or "multiple targets with the named
> property"? Actually, that's not even so very interesting. I guess I don't
> like the idea that somebody might type:

This is probably the same question as Mike's, but what would a
recursive propget yield? The same indented output as with multiple
targets right? I'd hate svn pg svn:mergeinfo -vR to return to the
mess it was.

> svn propget svn:mergeinfo *.c
>
> in one directory, and see one form of output, and then do exactly the same
> thing in other directory and see another form.
>
>> If you care, please have a look and a think. Alternatives are:
>>
>> B. Leave it as it is.
>
> I actually misread the finer details of your mail, and started to propose an
> alternative. In pre-send-the-mail review, though, I realized my mistake --
> I had just proposed exactly the state of trunk today. Apparently, my mind
> is saying "Leave it as it is."

I lean in the 'leave it as is' direction too, but as long as there is
some way to get the indented output with both pl and pg then anything
but D is ok with me.

Paul
Received on 2009-01-20 15:59:03 CET

This is an archived mail posted to the Subversion Dev mailing list.