[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue 2213 - setting a max diff size

From: Jon Bendtsen <jbendtsen_at_laerdal.dk>
Date: Fri, 16 Jan 2009 17:05:05 +0100

On 16/01/2009, at 16.56, Greg Stein wrote:

> Smaller patches are definitely better. I'll take a look at these, but
> on this first patch, I noted a style problem: note that all of
> mailer.py uses a space after commas (e.g. in function call params).
> Your patches omit that space, rather than following the style.

Fixed. I think i did notice in my later patches and followed the style,
but i have now go through the other patches and fix any style issues.

JonB

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1029041

On 16/01/2009, at 16.56, Greg Stein wrote:

> Smaller patches are definitely better. I'll take a look at these, but
> on this first patch, I noted a style problem: note that all of
> mailer.py uses a space after commas (e.g. in function call params).
> Your patches omit that space, rather than following the style.

Fixed. I think i did notice in my later patches and followed the style,
but i have now go through the other patches and fix any style issues.

JonB

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1029041

Received on 2009-01-16 17:07:21 CET

This is an archived mail posted to the Subversion Dev mailing list.