Smaller patches are definitely better. I'll take a look at these, but
on this first patch, I noted a style problem: note that all of
mailer.py uses a space after commas (e.g. in function call params).
Your patches omit that space, rather than following the style.
On Fri, Jan 16, 2009 at 15:20, Jon Bendtsen <jbendtsen_at_laerdal.dk> wrote:
> Hi
>
> The attached PATCH is another way of solving issue 2213
> http://subversion.tigris.org/issues/show_bug.cgi?id=2213
> The method used in this PATCH is a byte count for each diff for
> each file, and once the limit for a diff of a file is reached, the rest
> of the diff for this file will be cut off, and the email will continue
> with the next file.
>
> Naturally the configration file accepts a default limit and
> individual limits per group.
>
> The PATCH is made against the latest? mailer.py from trunk,
> revision 35280
>
> Starting with revision 35280, this patch will cause complications
> with some of the other patches that i will be sending shortly.
>
> Applies fine:
> sameimportfix.txt
>
> Fuzzy helps:
> binary_file_endings.txt
>
> Problems and errors:
> header_detail.txt
> max_number_of_diffs.txt
> max_mail_size.txt
>
>
> My intention is that all the functionality in the patches should be
> available, so i am willing to do some work to get them all to apply
> cleanly or with fuzzy. I just dont know the order which to do it in,
> and i figured that once big patch that gave all the functionality
> would not be well liked.
>
> 6 patches will arrive
>
>
> JonB
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1028677
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1029003
Received on 2009-01-16 16:56:34 CET