[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r35055 - in trunk/subversion: include libsvn_auth_gnome_keyring libsvn_subr

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: Thu, 08 Jan 2009 07:14:27 -0800

Julian Foad wrote:
> Senthil Kumaran S wrote:
>> Arfrever Frehtes Taifersar Arahesis wrote:
>>> svn_auth_get_platform_specific_client_providers() and
>>> svn_auth_get_platform_specific_provider() could accept additional
>>> 'svn_boolean_t command_line' argument. If 'command_line==TRUE', then
>>> svn_auth_get_gnome_keyring_simple_provider() would be called with
>>> unlock_prompt_func==NULL and prompt_baton==NULL.
>> That is a good one, I shall come up with a patch with the above idea :)
>
> Instead of this function having internal knowledge of a particular
> command-line prompting function, it would be better for it to take a
> pointer to a prompting function and have no internal knowledge. (The
> file "auth.c" should not have to include "svn_cmdline.h".)

Agreed. This approach is preferable.

-Hyrum

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1011826
Received on 2009-01-08 16:14:58 CET

This is an archived mail posted to the Subversion Dev mailing list.