[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r34914 - branches/http-protocol-v2/subversion/libsvn_ra_serf

From: Greg Stein <gstein_at_gmail.com>
Date: Thu, 25 Dec 2008 00:06:38 -0800

On Dec 24, 2008, at 10:45, "Ben Collins-Sussman" <sussman_at_red-
bean.com> wrote:

> On Wed, Dec 24, 2008 at 10:56 AM, Greg Stein <gstein_at_gmail.com> wrote:
>> The old-fashioned code can cache the youngest rev.
> Oh? I need to find where that is. It wasn't in the session_t, so I
> assumed it wasn't being cached...

Sorry. I meant "can [now] cache". The old code fetches it, of course,
so it should now cache what it finds since you have a spot for it.


>> It also looks like the key compare is bad. How can you compare to
>> "svn"? Do you mean to compare just the first three letters?
> Doh, yeah. Will fix. I was mindlessly copying a similar strcmp
> earlier in the function that matches against the 'DAV:' header key.
> Btw, thanks for these reviews. It comforts me to go hacking into
> ra_serf, knowing that you're watching my back. :-)

Received on 2008-12-25 09:06:38 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.