Re: svn commit: r34914 - branches/http-protocol-v2/subversion/libsvn_ra_serf

From: Ben Collins-Sussman <sussman_at_red-bean.com>
Date: Wed, 24 Dec 2008 12:45:35 -0600

On Wed, Dec 24, 2008 at 10:56 AM, Greg Stein <gstein_at_gmail.com> wrote:
> The old-fashioned code can cache the youngest rev.

Oh? I need to find where that is. It wasn't in the session_t, so I
assumed it wasn't being cached...

>
> It also looks like the key compare is bad. How can you compare to
> "svn"? Do you mean to compare just the first three letters?

Doh, yeah. Will fix. I was mindlessly copying a similar strcmp
earlier in the function that matches against the 'DAV:' header key.

Btw, thanks for these reviews. It comforts me to go hacking into
ra_serf, knowing that you're watching my back. :-)

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=991780
Received on 2008-12-24 19:45:54 CET