[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Should svn_fs_fs__noderev_same_rep_key() accept NULL representation_t::uniquifier?

From: Kouhei Sutou <kou_at_cozmixng.org>
Date: Wed, 17 Dec 2008 22:01:11 +0900 (JST)

Hi,

In <4946A121.5030704_at_mail.utexas.edu>
  "Re: Should svn_fs_fs__noderev_same_rep_key() accept NULL representation_t::uniquifier?" on Mon, 15 Dec 2008 12:25:37 -0600,
  "Hyrum K. Wright" <hyrum_wright_at_mail.utexas.edu> wrote:

> >>> + return TRUE;
> >>> +
> >>> + if (a->uniquifier == NULL || b->uniquifier == NULL)
> >>> + return FALSE;
> >
> > (And, for brevity, the comparison of the whole representation_t pointers
> > 'a' and 'b' could use this form too:
> >
> > Index: subversion/libsvn_fs_fs/fs_fs.c
> > ===================================================================
> > --- subversion/libsvn_fs_fs/fs_fs.c (revision 34710)
> > +++ subversion/libsvn_fs_fs/fs_fs.c (working copy)
> > @@ -3423,10 +3423,7 @@
> > if (a == b)
> > return TRUE;
> >
> > - if (a && (! b))
> > - return FALSE;
> > -
> > - if (b && (! a))
> > + if (a == NULL || b == NULL)
> > return FALSE;
> >
> > if (a->offset != b->offset)
> > )
>
> Kou,
> Could you commit the changes to fs_fs.c?

I've committed the later of my patches in r34759.

Thanks,

--
kou
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=985678
Received on 2008-12-17 14:01:31 CET

This is an archived mail posted to the Subversion Dev mailing list.