[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Infinite re-prompts for user credentials

From: Alexander Thomas <alexander_at_collab.net>
Date: Fri, 12 Dec 2008 11:15:35 +0530

On Thu, 2008-12-11 at 09:37 -0500, C. Michael Pilato wrote:
> Alexander Thomas wrote:
> > On Wed, 2008-12-10 at 10:34 -0500, Mark Phippard wrote:
> >> Since I cannot really review the patch and understand it I left it.
> >> If that is what he did would it be an OK patch?
> >>
> > I believe what I did is on the API level. So is it good for commit?
>
> +1 if you change the docstrings to read
>
> "For infinite retries..."
>
> instead of
>
> "For infinite retry..."
>

Resending the patch, with your suggested modification.

[[[
A negative value to the retry_limit will re-prompt for user credentials
infinite times.

* subversion/libsvn_subr/ssl_client_cert_pw_providers.c
  (ssl_client_cert_pw_prompt_next_cred): Modified not to give up if a
   negative value is given as retry_limit.

* subversion/libsvn_subr/ssl_client_cert_providers.c
  (ssl_client_cert_prompt_next_cred): Modified not to give up if a
   negative value is given as retry_limit.

* subversion/libsvn_subr/username_providers.c
  (username_prompt_next_creds): Modified not to give up if a
   negative value is given as retry_limit.

* subversion/libsvn_subr/simple_providers.c
  (simple_prompt_next_creds): Modified not to give up if a
   negative value is given as retry_limit.

* subversion/include/svn_client.h
* subversion/include/svn_auth.h
  Fix doc to reflect above change.

Patch by: Alexander Thomas <alexander_at_collab.net>
]]]

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=983215

Received on 2008-12-12 11:43:30 CET

This is an archived mail posted to the Subversion Dev mailing list.