[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Infinite re-prompts for user credentials

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Thu, 11 Dec 2008 09:37:39 -0500

Alexander Thomas wrote:
> On Wed, 2008-12-10 at 10:34 -0500, Mark Phippard wrote:
>> On Wed, Dec 10, 2008 at 10:29 AM, C. Michael Pilato <cmpilato_at_collab.net> wrote:
>>> Ben Collins-Sussman wrote:
>>>> Sorry for not understanding, but why would a user ever want to be
>>>> re-prompted forever? I've always thought the 3-retries behavior was
>>>> deliberate and friendly.
>>> Yeah, I must agree. -1 on this change, unless perhaps it is implemented as
>>> a configuration option (in the 'servers' file) like 'max_auth_retries'.
>> I had started to type the same as you and Ben, but then I thought
>> perhaps Alex was just modifying this at the API level so that if a
>> tool like RapidSVN wants to provide infinite prompts they can do so?
>> Since I cannot really review the patch and understand it I left it.
>> If that is what he did would it be an OK patch?
> I believe what I did is on the API level. So is it good for commit?

+1 if you change the docstrings to read

   "For infinite retries..."

instead of

   "For infinite retry..."

C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on 2008-12-11 15:37:55 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.