[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Bugs using delete (instead of delete[]) with new[]

From: Shannon Barber <shannonb_at_mrmx.com>
Date: Mon, 8 Dec 2008 19:04:40 -0500

I recently have run several memory analysis tools on my one of my projects
and some corruption errors were detected in TortoiseSVN.dll.
The corruption is detected when a file-open dialog is closed.
Since Tortoise integrates with the shell, this is arguable an important bug
since every application is corrupting its free-store when open file dialogs
are closed.

There appears to be (at least) two locations where memory is allocated using
new[] but is freed using delete.
A review of the code searching for new[]'s and their corresponding delete or
delete[] might be the most effective way to fix this bug.
I have also included undecorated stack traces below (in case they help at
all).
(I searched the Flyspray task list and the ChangeLog.txt and saw no mention
of delete/new new[] nor delete regarding memory allocation.)

This is the version I am using:
TortoiseSVN 1.5.2, Build 13595 - 32 Bit , 2008/07/31 17:04:57
Subversion 1.5.1,
apr 1.2.12
apr-utils 1.2.12
berkeley db 4.4.20
neon 0.28.2
OpenSSL 0.9.8g 19 Oct 2007
zlib 1.2.3

First
                TortoiseSVN.dll 0x0005CB70
                TortoiseSVN.dll 0x0005D23F
                TortoiseSVN.dll 0x000599EC
                TortoiseSVN.dll 0x0006F368
                msvcr90.dll 0x000221FF
                TortoiseSVN.dll 0x0004FEB7
                TortoiseSVN.dll 0x0005007F
                TortoiseSVN.dll 0x0005014C
                ntdll.dll 0x000011A4
                ntdll.dll 0x0001CBA6
                ntdll.dll 0x00016173
                ntdll.dll 0x000162D5
                kernel32.dll 0x00001BB4
                TortoiseStub.dll 0x00007597

Second
                TortoiseSVN.dll 0x0005D342
                TortoiseSVN.dll 0x0005DDC9
                TortoiseOverlays.dll 0x0000CB72
                TortoiseOverlays.dll 0x0000D113
                TortoiseOverlays.dll 0x0000D6ED
                shell32.dll 0x0008ECCB
                shell32.dll 0x000419AC
                shell32.dll 0x0002F685
                shell32.dll 0x0002FB8F
                shell32.dll 0x0002FB57
                shell32.dll 0x0002FB1C
                shell32.dll 0x0002F8F4
                shell32.dll 0x000418EA
                shell32.dll 0x00036762
                shell32.dll 0x00041E97
                shell32.dll 0x00041696
                shell32.dll 0x000715D3
                comdlg32.dll 0x000068F9
                user32.dll 0x00008731
                user32.dll 0x00013740

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=981381
Received on 2008-12-09 01:06:34 CET

This is an archived mail posted to the Subversion Dev mailing list.