[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r34516 - trunk/subversion/libsvn_fs_fs

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: Tue, 02 Dec 2008 10:47:40 -0600

Greg Stein wrote:
> On Mon, Dec 1, 2008 at 18:59, <hwright_at_tigris.org> wrote:
>> ...
>> +++ trunk/subversion/libsvn_fs_fs/fs_fs.c Mon Dec 1 18:59:42 2008 (r34516)
>> ...
>> + SVN_ERR(svn_stream_close(manifest_stream));
>> + SVN_ERR(svn_stream_close(pack_stream));
>> + svn_pool_destroy(iterpool);
>>
>> /* Update the max-pack-rev file to reflect our newly packed shard. */
>> final_path = svn_path_join(fs_path, PATH_MAX_PACKED_REV, pool);
>> - SVN_ERR(svn_stream_open_unique(&stream, &tmp_path, fs_path,
>> + SVN_ERR(svn_stream_open_unique(&tmp_stream, &tmp_path, fs_path,
>> svn_io_file_del_none, pool, pool));
>> - SVN_ERR(svn_stream_printf(stream, pool, "%ld\n",
>> + SVN_ERR(svn_stream_printf(tmp_stream, pool, "%ld\n",
>> (svn_revnum_t) ((shard + 1) * max_files_per_dir)));
>> - SVN_ERR(svn_stream_close(stream));
>> + SVN_ERR(svn_stream_close(tmp_stream));
>> SVN_ERR(svn_fs_fs__move_into_place(tmp_path, final_path, final_path, pool));
>
> Dunno what the definition of "pool" is. scratch? result?
>
> In any case, you could do this last bit in "iterpool" before destroying it.

Did the latter in r34522.

-Hyrum

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=598110

Received on 2008-12-02 17:48:04 CET

This is an archived mail posted to the Subversion Dev mailing list.