[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] svn_client_commit2/3 doesn't correctly honor recursive flag anymore

From: Martin Hauner <martin.hauner_at_gmx.net>
Date: Sat, 29 Nov 2008 22:48:36 +0100

Hi Daniel,

On 29.11.2008 19:17 Uhr, Daniel Shahaf wrote:
> Martin Hauner wrote on Sat, 29 Nov 2008 at 17:59 +0100:
>> Hi,
>> svn_client_commit2/3 (since 1.5.0) does no longer behave like it did before
>> (1.4.x).
> Yes, good catch. But svn/main.c also has to be changed in the same way
> (I found this as soon as I tried to reproduce the regression with the
> cmdline client). And when I do this, commit_tests 26 breaks:

oh, I missed that. I will run the tests the next time :)

> [..]
> It seems that it checks for this specific behaviour. It even has
> a comment explaining it:
> ### These days, -N should be equivalent to --depth=files in almost
> ### all cases. There are some exceptions (e.g., status), but commit
> ### is not an exception.
> The comment, however, seems inaccurate, since 'svn1.4 ci -N' definitely
> does (the equivalent of) svn_depth_empty.
> Have the semantics of 'commit' been intentionally changed? Or should we
> just fix the test to expect -N to mean svn_depth_empty?

I think the test should be corrected. I would find it surprising if it was
intentionally changed. Why spend all the work to maintain backward compatibility
of the old api when such basic behavior gets changed?

But i'm mostly just a casual bystander on this list, so what do i know ;-)

Subcommander 2.0.0 Beta 4, 1.2.4 - http://subcommander.tigris.org
a Win32/Unix/MacOSX subversion GUI client & diff/merge tool.
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-11-29 22:48:55 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.