Re: Trunk build broken: Re: svn commit: r34258 - trunk

Greg Stein wrote:
> The flags are on again, in r34280. [...]

> - CFLAGS="$CFLAGS -Wpointer-arith -Wwrite-strings -Wshadow"
> + AC_MSG_NOTICE([maintainer-mode: adding GCC warning flags])
> + CFLAGS="$CFLAGS -Wpointer-arith -Wwrite-strings -Wshadow
> -ansi -std=c99 -Wall -Wformat=2 -Wunused -Waggregate-return
> -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes
> -Wmissing-declarations -Wno-multichar -Wredundant-decls
> -Wnested-externs -Wunreachable-code -Winline -Wno-long-long"

Note that "-ansi" means "-std=c89" which is contradicted by "-std=c99".
We should use just "-ansi".

I also recommend:
  -Wdeclaration-after-statement (we make this mistake fairly often)
  -Wundef

and I also use:
  -Wcast-qual (results in several warnings, some incurable)
  -Wno-system-headers (don't warn about things in system headers [1])

[1] This is the default in GCC 4.1.2, but I think I started using it
with a version of GCC in which it was not the default.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-11-21 12:11:49 CET