[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: FSFS safety violation caught by testing? (r34197)

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Fri, 14 Nov 2008 20:42:25 -0500

David Glasser wrote:
> On Fri, Nov 14, 2008 at 3:25 PM, David Glasser <glasser_at_davidglasser.net> wrote:
>> On Fri, Nov 14, 2008 at 11:41 AM, C. Michael Pilato <cmpilato_at_collab.net> wrote:
>>> cmpilato_at_tigris.org wrote:
>>>> Author: cmpilato
>>>> Date: Fri Nov 14 11:34:25 2008
>>>> New Revision: 34197
>>>> Log:
>>>> Bang support for --server-minor-version testing into the C test
>>>> framework, and use it in the FS and Repos tests.
>>>> NOTE: Only one failure that I didn't expect turned up:
>>>> $ ./fs-test --server-minor-version=4 --fs-type=fsfs
>>>> ...
>>>> subversion/tests/libsvn_fs/fs-test.c:369: (apr_err=160000)
>>>> svn_tests: the transaction name '0-3' was reused
>>>> FAIL: lt-fs-test 5: check that transaction names are not reused
>>>> ...
>>> Does an FSFS hacker want to comment on this? Do we have a problem when
>>> using trunk code on --pre-1.5-compatible FSFS repositories?
>> Unless something has changed the C tests don't pay attention to
>> --server-minor-version.
> ... OK, OK, now I read the log message :)
> Unconvinced that --server-minor-version makes sense for non-RA tests, but sure.

I don't see how the C tests would stand out as unique against, say, ra-local
tests in this manner. We need a way to make sure that newer FS code doesn't
croak on old formats (or *does* croak predictably as the case might be).
This seemed like the easiest way to get there from here.

> Anyway, I think the transaction name algorithm changed in 1.5; check
> libsvn_fs_fs/structure for details.

Okey dokey.

C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-11-15 02:42:31 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.