Re: FSFS safety violation caught by testing? (r34197)

On Fri, Nov 14, 2008 at 3:25 PM, David Glasser <glasser_at_davidglasser.net> wrote:
> On Fri, Nov 14, 2008 at 11:41 AM, C. Michael Pilato <cmpilato_at_collab.net> wrote:
>> cmpilato_at_tigris.org wrote:
>>> Author: cmpilato
>>> Date: Fri Nov 14 11:34:25 2008
>>> New Revision: 34197
>>>
>>> Log:
>>> Bang support for --server-minor-version testing into the C test
>>> framework, and use it in the FS and Repos tests.
>>>
>>> NOTE: Only one failure that I didn't expect turned up:
>>>
>>> $ ./fs-test --server-minor-version=4 --fs-type=fsfs
>>> ...
>>> subversion/tests/libsvn_fs/fs-test.c:369: (apr_err=160000)
>>> svn_tests: the transaction name '0-3' was reused
>>> FAIL: lt-fs-test 5: check that transaction names are not reused
>>> ...
>>
>> Does an FSFS hacker want to comment on this? Do we have a problem when
>> using trunk code on --pre-1.5-compatible FSFS repositories?
>
> Unless something has changed the C tests don't pay attention to
> --server-minor-version.

... OK, OK, now I read the log message :)

Unconvinced that --server-minor-version makes sense for non-RA tests, but sure.

Anyway, I think the transaction name algorithm changed in 1.5; check
libsvn_fs_fs/structure for details.

--dave

-- 
David Glasser | glasser@davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org