[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Four failing tests on trunk with ra_serf.

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Fri, 14 Nov 2008 00:46:58 +0000

On Thu, 2008-11-13 at 14:45 -0500, Justin Erenkrantz wrote:
> On Thu, Nov 13, 2008 at 6:33 AM, Julian Foad <julianfoad_at_btopenworld.com> wrote:
> > As three of these are tree-conflict tests, and the other is in the same
> > sort of area, I had that much of a look at the test log. The fact that
> > it all works with Neon says to me that these are all bugs in (RA-)Serf.
> In my experience, that is not usually a correct assumption - it could
> often be that ra_neon is seeing the same issue but is hiding the
> fundamental error in other ways.
> Frankly, IMO, if you break the tests, you should fix the code. It's
> not fair to have people say, "Oh, I broke the code and I won't bother
> to fix it." That's not how I believe we should operate 'round here.
> If you need help understanding the code, plenty of us are around to
> assist - but if you are the one who breaks some code, you should make
> a legitimate attempt to fix it. A lot of us put a lot of work to get
> the code fully passing the regression tests - and to have folks
> essentially say, "I broke the code and won't fix it" isn't respectful
> neighborly behavior in my view.
> My $.02. -- justin

Justin, I hear you. I guess it depends on whether the code is more like
"stable and part of the system" or more like "still being developed". I
had the feeling it was still being developed (our official designation,
AFAIK, is "experimental"), albeit in a well progressed stage where it's
usable, but I'm admittedly out of touch and may have the wrong feeling.
Sorry for the bad vibes.

All the code I'm working with is supposed to be RA-neutral and I don't
think it does anything fancy with the RA layers. Yes, sometimes Neon and
Local and Svn are all seeing the same issue but hiding it in their
various ways, but when code works with the three well-established
layers, I hope you can see why I look to people interested in Serf to
either make Serf compatible with the others or explain why the calling
code is wrong.

Would you say, then, that we've reached the point where we should all be
treating Serf as part of the product and paying it as much attention as
Neon/svn/local? One thing we should do to cement this is ask Lieven to
get the Serf build-bot running on par with the others, not just the
present once a day.

- Julian

To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-11-14 01:47:17 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.