On Nov 12, 2008, at 1:39, Kamesh Jayachandran <kamesh_at_collab.net> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
>>
>> Modified: trunk/subversion/libsvn_subr/io.c
>> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_subr/io.c?pathrev=34152&r1=34151&r2=34152
>> ===
>> ===
>> ===
>> =====================================================================
>> --- trunk/subversion/libsvn_subr/io.c Tue Nov 11 16:40:57
>> 2008 (r34151)
>> +++ trunk/subversion/libsvn_subr/io.c Tue Nov 11 21:47:14
>> 2008 (r34152)
>> @@ -278,13 +278,17 @@ temp_file_child_cleanup_handler(void *ba
>>
>>
>> svn_error_t *
>> -svn_io_open_unique_file2(apr_file_t **f,
>> - const char **unique_name_p,
>> - const char *path,
>> - const char *suffix,
>> - svn_io_file_del_t delete_when,
>> - apr_pool_t *pool)
>> +svn_io_open_uniquely_named(apr_file_t **f,
>> + const char **unique_name_p,
>> + const char *dirpath,
>> + const char *filename,
>> + const char *suffix,
>> + svn_io_file_del_t delete_when,
>> + apr_pool_t *result_pool,
>> + apr_pool_t *scratch_pool)
>
> Do you intend svn_io_open_uniquely_named to be a public function? If
> so
> prototype in the public headers, else rename it to something that does
> not start with 'svn' and add 'static' mark
Yes, it will be public, along with svn_io_open_unique_file3. I intend
to submit all that work tomorrow after some additional coding, doc,
and testing.
This unit of work was a little more seperable, so I didn't wait. (tho
I could have jiggered things with some more undo/work, I left the func
refactoring in there)
Thx,
-g
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-11-12 08:32:56 CET