[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r34152 - in trunk/subversion: libsvn_fs_fs libsvn_subr libsvn_wc

From: Kamesh Jayachandran <kamesh_at_collab.net>
Date: Wed, 12 Nov 2008 12:09:34 +0530

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

>
> Modified: trunk/subversion/libsvn_subr/io.c
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_subr/io.c?pathrev=34152&r1=34151&r2=34152
> ==============================================================================
> --- trunk/subversion/libsvn_subr/io.c Tue Nov 11 16:40:57 2008 (r34151)
> +++ trunk/subversion/libsvn_subr/io.c Tue Nov 11 21:47:14 2008 (r34152)
> @@ -278,13 +278,17 @@ temp_file_child_cleanup_handler(void *ba
>
>
> svn_error_t *
> -svn_io_open_unique_file2(apr_file_t **f,
> - const char **unique_name_p,
> - const char *path,
> - const char *suffix,
> - svn_io_file_del_t delete_when,
> - apr_pool_t *pool)
> +svn_io_open_uniquely_named(apr_file_t **f,
> + const char **unique_name_p,
> + const char *dirpath,
> + const char *filename,
> + const char *suffix,
> + svn_io_file_del_t delete_when,
> + apr_pool_t *result_pool,
> + apr_pool_t *scratch_pool)

Do you intend svn_io_open_uniquely_named to be a public function? If so
prototype in the public headers, else rename it to something that does
not start with 'svn' and add 'static' marker.

With regards
Kamesh Jayachandran
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFJGnol3WHvyO0YTCwRAoKrAJ9UWtwpoYrupn/H9vOTyyfDPVPqTACbB9tP
g4wchqB5mNCuvavZqDTEkFw=
=6Fb4
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-11-12 07:37:08 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.