ah. oop. didn't notice the original was hwright... heh :-P
Need to turn on more gcc warnings/errors, me thinks.
On Sun, Oct 19, 2008 at 8:47 AM, Bert Huijben <bert_at_vmoo.com> wrote:
>> -----Original Message-----
>> From: Greg Stein [mailto:gstein_at_gmail.com]
>> Sent: Sunday, October 19, 2008 5:28 PM
>> To: dev_at_subversion.tigris.org; rhuijben_at_tigris.org
>> Subject: Re: svn commit: r33744 -
>> trunk/subversion/bindings/javahl/native
>>
>> Heh. Did you write 33739 and not even compile it before checking it in?
>> :-P
>
> Why do you ask me?
>
> Maybe hwright did in r33739, or maybe his compiler marked it as a warning as
> I saw before.
>
> I just fixed the windows buildbot compilation with r33744. (The unix and mac
> buildbots were green at that time).
>
> Bert
>>
>> On Sat, Oct 18, 2008 at 4:40 PM, <rhuijben_at_tigris.org> wrote:
>> > Author: rhuijben
>> > Date: Sat Oct 18 16:40:38 2008
>> > New Revision: 33744
>> >
>> > Log:
>> > * subversion/bindings/javahl/native/StatusCallback.cpp
>> > (StatusCallback::callback): Following up on r33739, return
>> SVN_NO_ERROR
>> > to fix compilation.
>> >
>> > Modified:
>> > trunk/subversion/bindings/javahl/native/StatusCallback.cpp
>> >
>> > Modified: trunk/subversion/bindings/javahl/native/StatusCallback.cpp
>> > URL:
>> http://svn.collab.net/viewvc/svn/trunk/subversion/bindings/javahl/nativ
>> e/StatusCallback.cpp?pathrev=33744&r1=33743&r2=33744
>> >
>> =======================================================================
>> =======
>> > --- trunk/subversion/bindings/javahl/native/StatusCallback.cpp Sat
>> Oct 18 16:24:08 2008 (r33743)
>> > +++ trunk/subversion/bindings/javahl/native/StatusCallback.cpp Sat
>> Oct 18 16:40:38 2008 (r33744)
>> > @@ -54,6 +54,8 @@ StatusCallback::callback(void *baton,
>> > {
>> > if (baton)
>> > ((StatusCallback *)baton)->doStatus(path, status);
>> > +
>> > + return SVN_NO_ERROR;
>> > }
>> >
>> > /**
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: svn-unsubscribe_at_subversion.tigris.org
>> > For additional commands, e-mail: svn-help_at_subversion.tigris.org
>> >
>> >
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-10-19 18:17:23 CEST