[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Correctly handle SVN_INVALID_REVNUM in svn_repos_get_logs4 even for start < head

From: David Glasser <glasser_at_davidglasser.net>
Date: Wed, 15 Oct 2008 13:42:56 -0700

start = 0, end = SVN_INVALID_REVNUM?

--dave

On Tue, Oct 14, 2008 at 2:38 PM, Hyrum K. Wright
<hyrum_wright_at_mail.utexas.edu> wrote:
> David Glasser wrote:
>> I'd run tests and commit, but apparently we now require a newer
>> sqlite3 than my work machine has installed, and while I recognize that
>> sqlite3 is really really easy to build, it's still more activation
>> energy than I have today. Sorry.
>>
>> [[[
>> * subversion/libsvn_repos/log.c
>> (svn_repos_get_logs4): For the ascending-revisions case, handle
>> SVN_INVALID_REVNUM
>> arguments correctly.
>> ]]]
>>
>> Index: subversion/libsvn_repos/log.c
>> ===================================================================
>> --- subversion/libsvn_repos/log.c (revision 33643)
>> +++ subversion/libsvn_repos/log.c (working copy)
>> @@ -1612,10 +1612,10 @@
>> SVN_ERR(svn_fs_youngest_rev(&head, fs, pool));
>>
>> if (! SVN_IS_VALID_REVNUM(start))
>> - start = head;
>> + hist_start = start = head;
>>
>> if (! SVN_IS_VALID_REVNUM(end))
>> - end = head;
>> + hist_end = end = head;
>>
>> /* Check that revisions are sane before ever invoking receiver. */
>> if (start > head)
>
> Out of curiosity, do you have an example which demonstrates this problem?
>
> -Hyrum
>
>

-- 
David Glasser | glasser@davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-10-15 22:43:11 CEST

This is an archived mail posted to the Subversion Dev mailing list.