Re: [PATCH] Correctly handle SVN_INVALID_REVNUM in svn_repos_get_logs4 even for start < head

David Glasser wrote:
> I'd run tests and commit, but apparently we now require a newer
> sqlite3 than my work machine has installed, and while I recognize that
> sqlite3 is really really easy to build, it's still more activation
> energy than I have today. Sorry.
>
> [[[
> * subversion/libsvn_repos/log.c
> (svn_repos_get_logs4): For the ascending-revisions case, handle
> SVN_INVALID_REVNUM
> arguments correctly.
> ]]]
>
> Index: subversion/libsvn_repos/log.c
> ===================================================================
> --- subversion/libsvn_repos/log.c (revision 33643)
> +++ subversion/libsvn_repos/log.c (working copy)
> @@ -1612,10 +1612,10 @@
> SVN_ERR(svn_fs_youngest_rev(&head, fs, pool));
>
> if (! SVN_IS_VALID_REVNUM(start))
> - start = head;
> + hist_start = start = head;
>
> if (! SVN_IS_VALID_REVNUM(end))
> - end = head;
> + hist_end = end = head;
>
> /* Check that revisions are sane before ever invoking receiver. */
> if (start > head)

Out of curiosity, do you have an example which demonstrates this problem?

-Hyrum