[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: [PATCH] Fix for renaming errors on Samba working cop

From: Alan Wood <alan.wood_at_clear.net.nz>
Date: Wed, 08 Oct 2008 20:41:06 +1300

On 7 Oct 2008 at 12:15, Bert Huijben wrote:

>
> I see the problem you experience and I think we can resolve it, but your
> patch might fail before the original retry loop if the rename fails for
> another reason.
>
> If the file is locked the SetAtttributes might fail. In this case
> SVN_ERR(..) will return the error before retrying the rename itself.
>
Replacing the retry loop with this should achieve the correct flow, but I haven't
seen many coding standards that would approve :-)

 WIN32_RETRY_LOOP(status,
 (APR_TO_OS_ERROR(status) == ERROR_ACCESS_DENIED &&
 svn_io_set_file_read_write(from_path, TRUE, pool),
 apr_file_rename(from_path_apr, to_path_apr, pool)));

Alan

>Bert
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
> For additional commands, e-mail: dev-help_at_subversion.tigris.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org

Received on 2008-10-08 09:42:30 CEST

This is an archived mail posted to the Subversion Dev mailing list.