On 7 Oct 2008 at 12:15, Bert Huijben wrote:

>
> I see the problem you experience and I think we can resolve it, but your
> patch might fail before the original retry loop if the rename fails for
> another reason.
>
> If the file is locked the SetAtttributes might fail. In this case
> SVN_ERR(..) will return the error before retrying the rename itself.
>
Replacing the retry loop with this should achieve the correct flow, but I haven't
seen many coding standards that would approve :-)

  WIN32_RETRY_LOOP(status,
  (APR_TO_OS_ERROR(status) == ERROR_ACCESS_DENIED &&
    svn_io_set_file_read_write(from_path, TRUE, pool),
          apr_file_rename(from_path_apr, to_path_apr, pool)));


      Alan

>         Bert
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org