On Wed, Oct 1, 2008 at 7:44 PM, Ben Collins-Sussman
<sussman_at_red-bean.com> wrote:
> On Wed, Oct 1, 2008 at 10:08 AM, Ivan Zhakov <ivan_at_visualsvn.com> wrote:
>
>> Two apache modules could easy handle the same public url. You just to
>> register handler hook before mod_dav_svn and then return DECLINED if
>> url is not accepted. For example if it doesn't have cmd=something in
>> args. And return OK in other cases. mod_svn_view module uses this
>> approach for implementing Subversion web interface on the same URLs as
>> Subversion.
>
> Aha! I completely forgot about this option. Thanks Ivan!
>
> This strategy gives us the best of both worlds. It allows us to write
> a 'clean' mod_svn module with no baggage, minimal code, totally
> streamlined and aligned with svn_ra.h. But it also allows mod_dav_svn
> to coexist and speak the older protocol at the same public URL.
>
> If an admin wants to upgrade to the faster protocol, he just installs
> mod_svn next to mod_dav_svn, then asks his users to upgrade their
> clients when they're ready.
>
> Am I missing anything here?
>
This is great. Only one thing I'm missing what is the reason to use
repository root and encode path parameter in query args? From my point
of it's much better to work on target URL, without knowledge of
repository root. I mean:
GET /repos/trunk/foo.c?cmd=get-file&r=23
instead of
GET /repos?cmd=get-file&r=23&path=/trunk/foo.c
Because resolving repository root takes additional workaround unless
we have working copy.
Another bikeshed comment: I propose use 'svn-cmd' instead of 'cmd' to
be able serve several services (Subversion web access for example) on
the same URL.
--
Ivan Zhakov
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-10-01 21:39:11 CEST