[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Working copy on Samba share

From: <alan.wood_at_clear.net.nz>
Date: Mon, 22 Sep 2008 23:42:43 +1200

Hi All,
I have been working on trying to make subversion working copies
behave on Samba shares.
This patch seems to solve two issues that I have seen.
The problems happen after a commit when the working copy is being
The first is that a rename would sometimes fail from .svn/tmp/blah
to .svn/blah2 or .svn/dir-props to .svn/dir-props-base
The second fault would be cannot access dir/.svn/lock. Both would
report 'permission denied'.
I have managed to trace this to places in the code where
GetFileAttributes and SetFileAttributes are called.
Both of these functions suffer from the same fate as described at
the top of io.c and which the macro WIN32_RETRY_LOOP() was written
to alleviate.
The FileAttribue calls are in the apr_ routines apr_stat() and
This patch wraps these two apr_ routines in the WIN32_RETRY_LOOP()
I have patched all uses of these two routines even though I have
only managed to trace issues occurring in
svn_io_set_file_read_write() called from svn_io_file_rename() and
Tests so far confirm that the issues that I have been able to
reproduce have disappeared.

Alan Wood

To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org

Received on 2008-09-22 13:50:25 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.