The mime type meant that it didn't display it... but ugh. text/x-diff
*is* listed as a valid one. Sigh.
My bad. I thought we said "text/plain" and that was it.
Sorry, Arfrever...
On Sun, Sep 21, 2008 at 10:28 PM, Daniel Shahaf <d.s_at_daniel.shahaf.name> wrote:
> Greg Stein wrote on Sun, 21 Sep 2008 at 21:37 -0700:
>> On Sun, Sep 21, 2008 at 8:33 PM, Peter Samuelson <peter_at_p12n.org> wrote:
>> > [Greg Stein]
>> >> [please review the PATCH mail submission guidelines in hacking.html;
>> >> it was very difficult to review your patch as emailed]
>> >
>
> Incredibly non-specific :)
>
> As far as I know, Arfrever did follow the patch submission guidelines.
> Yes, the log message and the patch were separated (one inline and one
> attached), which makes review harder, but that's about the only thing
> I can think of. (The patch even included the 'diff -p' headers, that
> most patches don't have.)
>
>> > Shrug - it came through my MUA inline.
>>
>> Not all MUAs do, which is why we established some guides. When it
>> becomes hard to read, then people simply don't. Arfrever and I had
>> discussed this before, so I was motivated. If it had been for (say)
>> the client lib? Nah. I wouldn't have looked at it, and that is Not
>> Good.
>
> Agreed. But you still don't say *why* you wouldn't have looked at it
> (what made reading it hard).
>
> Daniel
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-09-22 07:49:37 CEST