Re: [PATCH] Issue 2489: Removing direct dependency to DBUS

2008-09-18 13:11:26 Alexander Thomas napisał(a):
>
> On Wed, 2008-09-17 at 20:34 +0200, Arfrever Frehtes Taifersar Arahesis wrote:
> > 2008-09-17 09:29:10 Senthil Kumaran S napisał(a):
> > > Alexander Thomas wrote:
> > > > [[[
> > > > Remove direct dependency to D-Bus library in GNOME Keyring.
> > > >
> ...
> > > > ]]]
> > >
> > > Committed in r33118.
> >
> > This patch is wrong.
> > See r31269.
> >
> > The following warning is now shown when Subversion is run outside X session:
> > ** (process:NUMBER): WARNING **: couldn't connect to dbus session bus: dbus-launch failed to autolaunch D-Bus session: Autolaunch error: X11 initialization failed.
> >
>
> Its seems like r31269 was introduced to suppress this warning.?

Yes.

> Another important fact is that for just one function we introducing
> a new dependency.

It doesn't matter, because D-Bus is an unconditional dependency of GNOME
Keyring.

> AFAIK This warning can be suppressed by setting the
> DBUS_SESSION_BUS_ADDRESS env variable or by setting the
> GNOME_KEYRING_SOCKET evn variable.

We cannot expect that users will know these variables (especially what values
should be set).

This warning is shown even for users which don't have access to X session.
(I tested by using Subversion in tty1, while X session was owned by another
user.)

> By the way, when Subversion is ran outside X session and if the keyring
> is locked, what is really happening ?

After the aforementioned warning, Subversion asks if to store password in
plaintext form.

-- 
Arfrever Frehtes Taifersar Arahesis