Re: [PATCH] Issue 2489: Removing direct dependency to DBUS

On Wed, 2008-09-17 at 20:34 +0200, Arfrever Frehtes Taifersar Arahesis wrote:
> 2008-09-17 09:29:10 Senthil Kumaran S napisał(a):
> > Alexander Thomas wrote:
> > > [[[
> > > Remove direct dependency to D-Bus library in GNOME Keyring.
> > >
...
> > > ]]]
> >
> > Committed in r33118.
>
> This patch is wrong.
> See r31269.
>
> The following warning is now shown when Subversion is run outside X session:
> ** (process:NUMBER): WARNING **: couldn't connect to dbus session bus: dbus-launch failed to autolaunch D-Bus session: Autolaunch error: X11 initialization failed.
>

Its seems like r31269 was introduced to suppress this warning.?

IMHO by calling dbus_bus_get() function we unnecessarily holding a dbus
connection and also its called multiple times one from SVN and from
gnome-keyring. Another important fact is that for just one function we
introducing a new dependency.

AFAIK This warning can be suppressed by setting the
DBUS_SESSION_BUS_ADDRESS env variable or by setting the
GNOME_KEYRING_SOCKET evn variable.

By the way, when Subversion is ran outside X session and if the keyring
is locked, what is really happening ?

-AT

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-09-18 13:12:26 CEST