[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r33085 - in trunk:

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Tue, 16 Sep 2008 00:45:54 +0300 (Jerusalem Daylight Time)

I looked at the patch earlier today, and had just one minor issue (too
minor to post about separately then):

Don't we want to add a check that --with-no-revprops and either
--with-revprop or --with-all-revprops aren't used together? That is,
'svn log --with-no-revprops --with-all-revprops' should be disallowed.

Daniel

kfogel_at_tigris.org wrote on Mon, 15 Sep 2008 at 14:35 -0700:
> Author: kfogel
> Date: Mon Sep 15 14:35:55 2008
> New Revision: 33085
>
> Log:
> Add new command line switch "--with-no-revprops" to the svn log CLI.
> Extend the DAV protocol with a "no-revprops" flag, and update ra_serf
> and ra_neon to send this flag if the revprops array is empty. This
> brings the DAV protocol on par with the SVN protocol, and exposes this
> functionality to command line users.
>
> Patch by: Eirik Bjørsnøs <eirbjo-Re5JQEeQqe8AvxtiuMwx3w_at_public.gmane.org>
> (Only very minor tweaks by me, such as updating the getopt test data.)
>
> * subversion/mod_dav_svn/reports/log.c
> (dav_svn__log_report): Read "no-revprops" and leave an empty array
> of rev-props to fetch.
>
> * subversion/libsvn_ra_serf/log.c
> (svn_ra_serf__get_log): Add "<no-revprops/>" to log report request
> if revprops array is empty.
>
> * subversion/libsvn_ra_neon/log.c
> (svn_ra_neon__get_log): Add "<no-revprops/>" to log report request
> if revprops array is empty.
>
> * subversion/svn/cl.h
> (svn_cl__opt_state_t): Add no_revprops. Fix existing comment, too.
>
> * subversion/svn/log-cmd.c
> (svn_cl__log): Check for --with-no-revprops only being used in XML mode.
> (svn_cl__log): Create an empty revprops array if no_revprops is set.
>
> * subversion/svn/main.c
> (svn_cl__longopt_t) Add opt_with_no_revprops
> (svn_cl__options) Add "with-no-revprops" option
> (main) Check for opt_with_no_revprops being set
>
> * notes/webdav-protocol
> (log-report) Add "no-revprops" option
>
> * subversion/tests/cmdline/getopt_tests_data/svn_help_log_switch_stdout:
> Adjust for above.
>
> Modified:
> trunk/notes/webdav-protocol
> trunk/subversion/libsvn_ra_neon/log.c
> trunk/subversion/libsvn_ra_serf/log.c
> trunk/subversion/mod_dav_svn/reports/log.c
> trunk/subversion/svn/cl.h
> trunk/subversion/svn/log-cmd.c
> trunk/subversion/svn/main.c
> trunk/subversion/tests/cmdline/getopt_tests_data/svn_help_log_switch_stdout

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-09-15 23:46:14 CEST

This is an archived mail posted to the Subversion Dev mailing list.