[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r32996 - in trunk/subversion: include libsvn_subr

From: Greg Stein <gstein_at_gmail.com>
Date: Tue, 9 Sep 2008 09:04:01 -0700

Roll back a change? Dude. They are TWO line changes. If somebody
doesn't like it, then just apply a change to remove it. "Roll back" is
for large changes. These are about as small a change as possible.

They are harder to review because you must review a dozen emails. Put
those dozen changes into one revision and just go thru it once.

Cheers,
-g

On Tue, Sep 9, 2008 at 8:31 AM, Blair Zajac <blair_at_orcaware.com> wrote:
> Agreed that it was spammy, but it's easier to roll back an individual change
> if somebody's not happy about adding const to one method.
>
> I think I would still do it this way as it is easier to review and see where
> the const propagates to get it to work.
>
> Blair
>
> Greg Stein wrote:
>>
>> In the future, could you add const in one pass and revision rather than a
>> dozen 2-line changes? This series was real spammy and no easier to review
>> (arguably harder)
>>
>> Thx,
>> -g
>>
>>
>> On Sep 9, 2008, at 2:16, blair_at_tigris.org wrote:
>>
>>> Author: blair
>>> Date: Mon Sep 8 23:16:32 2008
>>> New Revision: 32996
>>>
>>> Log:
>>> * subversion/include/svn_cache.h,
>>> * subversion/libsvn_subr/cache.c
>>> (svn_cache_iter)
>>> Take a const svn_cache_t * instead of a svn_cache_t *.
>>>
>>> Modified:
>>> trunk/subversion/include/svn_cache.h
>>> trunk/subversion/libsvn_subr/cache.c
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-09-09 18:04:14 CEST

This is an archived mail posted to the Subversion Dev mailing list.