[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r32996 - in trunk/subversion: include libsvn_subr

From: Blair Zajac <blair_at_orcaware.com>
Date: Tue, 09 Sep 2008 08:31:32 -0700

Agreed that it was spammy, but it's easier to roll back an individual change if
somebody's not happy about adding const to one method.

I think I would still do it this way as it is easier to review and see where the
const propagates to get it to work.

Blair

Greg Stein wrote:
> In the future, could you add const in one pass and revision rather than
> a dozen 2-line changes? This series was real spammy and no easier to
> review (arguably harder)
>
> Thx,
> -g
>
>
> On Sep 9, 2008, at 2:16, blair_at_tigris.org wrote:
>
>> Author: blair
>> Date: Mon Sep 8 23:16:32 2008
>> New Revision: 32996
>>
>> Log:
>> * subversion/include/svn_cache.h,
>> * subversion/libsvn_subr/cache.c
>> (svn_cache_iter)
>> Take a const svn_cache_t * instead of a svn_cache_t *.
>>
>> Modified:
>> trunk/subversion/include/svn_cache.h
>> trunk/subversion/libsvn_subr/cache.c

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-09-09 17:31:54 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.