Re: mailer.py on Windows (and general svn-on-Windows commentary...)

Erik Huelsmann wrote:
> On Mon, Sep 8, 2008 at 8:36 PM, Trent Nelson
> <svn-dev-list_at_trentnelson.com> wrote:
>> mailer.py suffers a similar issue on Windows as svnperms.py, both
>> due to its use of popen() to run '/usr/bin/diff', as well as the
>> lack of said program on Windows.
>>
>> I used mailer.py as a reference when I started the svn2cq module,
>> which will eventually sync svn changes into a relational database,
>> although currently it's no more than a more object-oriented version
>> of mailer.py, without, er, the ability to send e-mail. As it's for
>> a client that's a Windows shop, I just packaged diff.exe and the
>> dependent .dlls in the module directory and replaced mailer.py's
>> popen with subprocess:
>>
>> http://code.google.com/p/svn2cq/source/browse/trunk/src/svn2cq/
>>
>> You know what would be nice? If the out-of-the-box Subversion 1.5
>> installer on Windows shipped not only mailer.py, but diff.exe and
>> the .dlls as well. Oh, and used subprocess, if available.
>
> How about -instead of using diff.exe- using the built-in diff engine
> (libsvn_diff)? It's available to use from the python bindings and - if
> you think that won't do it for you - you could instead use 'svnlook
> diff' which extracts the diffs right out of the repository, whenever
> possible.

Or maybe even Python's own difflib implementation (if version 2.3 or
greater)? :-)

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand