[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Anyone else having problems with empty mails from mailer.py?

From: Daniel Widenfalk <Daniel.Widenfalk_at_iar.se>
Date: Mon, 08 Sep 2008 12:04:53 +0200

Hi all,

I've been struggling for the last couple of weeks with an issue
in the mailer.py script: the mailer kept sending me completely
empty commit-mails!

After the initial hurdle of having to "learn" python I managed
to track down the issue to a "KeyValue" (I think it was) exception
being thrown, when building the subject line of the mail, after the
pipe to sendmail had been opened.

I think the root of the problem is that a group is matched by
the for_repos config, but no files in the commit matches the
for_paths config. The mailer then falls back to the default
settings for subject and receiver. The subject config contained
references to RE-matches (coll and repo) and the exception is
thrown when trying to replace them in the subject line template
but as no file was matched in "which_groups", the params hash was
set to the default value (that obviously did not include the coll
and repo substitutions). (was that description even remotely
understandable?)

Also, the problem only occurred when certain developers commit
to the server. It turned out that these users were connected to
groups that contained ".*" RE-matches for the repository.

The group description triggering this looks like this:

  [ruby-reviewers]
  for_repos = /path-to-repos/(?P<coll>[^/]*)/(?P<repo>.*)
  for_paths = .*\.rb

Has anyone else seen this behavior?

Regards
/Daniel Widenfalk

--------------------------------------------------------------
    Daniel Widenfalk IAR Systems AB
Senior Development Engineer Box 23051 (Islandsgatan 2)
                               S-75023 Uppsala, SWEDEN

Phone: +46 (0)18 167800 WWW: http://www.iar.se
Fax : +46 (0)18 167838 EMail: Daniel.Widenfalk_at_IAR.se
--------------------------------------------------------------

Legal note:

"The information contained in this message is confidential
 and may be legally privileged. It is intended solely for
 the addressee. Access to this message by anyone else is
 unauthorized. If you are not the intended recipient, any
 disclosure, copying or distribution of this message, or
 any action or omission taken by you in reliance on it, is
 prohibited and may be unlawful. Please immediately contact
 the sender if you have received this message in error."

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-09-08 12:05:27 CEST

This is an archived mail posted to the Subversion Dev mailing list.