[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Issue 2489 - Add support to JavaHL for storing SSL client certificate passphrases in OSX Keychain

From: Jeremy Whitlock <jcscoobyrs_at_gmail.com>
Date: Wed, 3 Sep 2008 11:10:34 -0600

Hi All,
    I have attached a patch to add support to JavaHL for storing SSL
client certificate passphrases in the OSX Keychain. Support for
caching SSL client certificate passphrases in the OSX Keychain was
added to Subversion core at r32860. The patch is also pasted at the
bottom of this mail and attached to Issue 2489:

http://subversion.tigris.org/issues/show_bug.cgi?id=2489

Please let me know if there is more I can do to get this approved.

-- 
Take care,
Jeremy Whitlock
http://www.thoughtspark.org
[[[
Add support to JavaHL for storing SSL client certificate passphrases in the
OSX Keychain.
* subversion/bindings/javahl/native/SVNClient.cpp
  (SVNClient::getContext): Add OSX Keychain SSL client certificate passphrase
   provider to the providers array.
]]]
Index: subversion/bindings/javahl/native/SVNClient.cpp
===================================================================
--- subversion/bindings/javahl/native/SVNClient.cpp (revision 32871)
+++ subversion/bindings/javahl/native/SVNClient.cpp (working copy)
@@ -1236,6 +1236,9 @@
 #ifdef SVN_HAVE_KEYCHAIN_SERVICES
     svn_auth_get_keychain_simple_provider(&provider, pool);
     APR_ARRAY_PUSH(providers, svn_auth_provider_object_t *) = provider;
+
+    svn_auth_get_keychain_ssl_client_cert_pw_provider(&provider, pool);
+    APR_ARRAY_PUSH(providers, svn_auth_provider_object_t *) = provider;
 #endif
 #ifdef SVN_HAVE_GNOME_KEYRING
     SVN_JNI_ERR(get_auth_provider(&provider, "gnome_keyring", "simple",


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org

Received on 2008-09-03 19:10:50 CEST

This is an archived mail posted to the Subversion Dev mailing list.