[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r32860 - in trunk/subversion: include libsvn_subr

From: Jeremy Whitlock <jcscoobyrs_at_gmail.com>
Date: Wed, 3 Sep 2008 09:24:37 -0600

>> Do you have a windows build environment available? This commit breaks
>> the build on Windows -- the win32-xp VS2005 builbot is down right now
>> so you won't have noticed. I'm not sure why this breaks the build
>> exactly since everything you added is blocked in defined(DARWIN) ||
>> Somehow svn_auth_get_keychain_ssl_client_cert_pw_provider is ending up
>> in the libsvn_subr.def (module definition file) when doing a clean
>> build. Not sure why this is (hand editing the file to remove it fixes
>> the build). I can try to look into this more later, but just wanted
>> to give you a heads up.
> It looks like the other darwin specific define is special cased in
> build/generator/extractor.py
> as not being available on windows.
> The .def format has been deprecated for a long time (It was the recommended method until Windows '95 arrived).
> Many other projects (including APR) have moved to using a specific define in their headers that is #defined to __declspec(dllexport) when compiling for a DLL on windows.
> Implementing a similar change in subversion would allow removing the .def generator support from the python generator.

Looks like Bert beat me to explaining this but who should "fix" this?

Take care,
Jeremy Whitlock
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-09-03 17:24:52 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.