Re: [PATCH] Issue 2489 - Add support for storing SSL client certificate passphrases in OSX Keychain.

>> [[[
>> Support storing SSL client certificate passphrases in OSX Keychain.
>>
>> * subversion/libsvn_subr/cmdline.c (svn_cmdline_set_up_auth_baton): Add OSX
>> Keychain SSL client certificate passphrase provider to the providers array.
>>
>> * subversion/libsvn_subr/macos_keychain.c (keychain_password_set,
>> keychain_password_get): Added NULL check for username.
>
> This change is logically not connected with adding support for SSL client
> certificate passphrase. This could be done in a separate patch (and separate
> commit), since it will be easy to segregate the logical changes for future
> reference, IMHO.
>
> Otherwise, I am +1 with this patch.

Actually it is. With SSL passphrases, the username is NULL which
would cause a runtime error. Without this change, there would be no
way to properly store SSL passphrases in the OSX Keychain.

-- 
Take care,
Jeremy Whitlock
http://www.thoughtspark.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org