Re: [PATCH] Issue 2489 - Add support for storing SSL client certificate passphrases in OSX Keychain.

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Jeremy,

Jeremy Whitlock wrote:
> [[[
> Support storing SSL client certificate passphrases in OSX Keychain.
>
> * subversion/libsvn_subr/cmdline.c (svn_cmdline_set_up_auth_baton): Add OSX
> Keychain SSL client certificate passphrase provider to the providers array.
>
> * subversion/libsvn_subr/macos_keychain.c (keychain_password_set,
> keychain_password_get): Added NULL check for username.

This change is logically not connected with adding support for SSL client
certificate passphrase. This could be done in a separate patch (and separate
commit), since it will be easy to segregate the logical changes for future
reference, IMHO.

Otherwise, I am +1 with this patch.

Thank You.
- --
Senthil Kumaran S
http://www.stylesen.org/

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFIvYQN9o1G+2zNQDgRAmbrAJ91K1Gycsb3qu4G274hxaCDE54OgQCdFGdY
PqUXJFVXd2xnHZGO+sGdpeg=
=zTkf
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-09-02 20:21:54 CEST