danielsh_at_tigris.org writes:
> And it also needs to say that LOGFILE won't be cleared. Suggested
> patch:
>
> Index: subversion/libsvn_wc/update_editor.c
> ===================================================================
> --- subversion/libsvn_wc/update_editor.c (revision 32790)
> +++ subversion/libsvn_wc/update_editor.c (working copy)
> @@ -1069,11 +1069,10 @@ open_root(void *edit_baton,
> }
>
>
> -/* Helper for delete_entry().
> +/* Helper for delete_entry() and do_entry_deletion().
>
> - Search an error chain (ERR) for evidence that a local mod was left.
> - If so, cleanup LOGFILE and return an appropriate error. Otherwise,
> - just return the original error chain.
> + If the error chain ERR contains evidence that a local mod was left
> + (an SVN_ERR_WC_LEFT_LOCAL_MOD error), clean ERR. Otherwise, return ERR.
> */
> static svn_error_t *
> leftmod_error_chain(svn_error_t *err,
>
> ?
"clear" not "clean" :-)
>> But also, 'err' is just the top of a possibly multi-error chain. Here
>> we're clear 'err', but not any of the other down errors (which could be
>> before or after 'err' in the chain). Shouldn't we clear everyone in the
>> chain?
>
> The docstring of svn_error_clear() says it clears everyone in the chain:
Okay. I guess that means when error A is a child of error B, then
A->pool == B->pool. Then the implementation makes sense.
-K
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-08-28 19:16:02 CEST