[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r32687 - branches/file-externals/subversion/libsvn_client

From: Blair Zajac <blair_at_orcaware.com>
Date: Wed, 27 Aug 2008 19:19:28 -0700

Karl Fogel wrote:
> blair_at_tigris.org writes:
>> --- branches/file-externals/subversion/libsvn_client/externals.c
>> +++ branches/file-externals/subversion/libsvn_client/externals.c
>> @@ -105,6 +109,10 @@ compare_external_items(svn_wc_external_i
>> * Pass CANCEL_FUNC, CANCEL_BATON to svn_wc_remove_from_revision_control.
>> *
>> * Use POOL for all temporary allocation.
>> + *
>> + * This function is not passed a svn_wc_adm_access_t to ensure that
>> + * what is being deleted is being opened separately so if there is a
>> + * lock on it, it cannot be deleted.
>> */
>> static svn_error_t *
>> relegate_dir_external(const char *path,
>
> I had to read that paragraph a few times. Maybe something like this
> instead?
>
> "Note: this function is not passed a svn_wc_adm_access_t. Instead,
> it separately opens the object being deleted, so that if there is a
> lock on that object, the object cannot be deleted."
>
> (Kudos in general on the thoroughness and clarity of your doc
> maintenance on this branch, though.)
>

>
> I think you've got your editor set to use TAB characters, causing the
> above new line to look misindented under certain circumstances. (You
> might want to check the rest of the branch for similar problems.)

Thanks, fixed in r32775 and r32776.

Regards,
Blair

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-08-28 04:19:47 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.