blair_at_tigris.org writes:
> --- branches/file-externals/subversion/libsvn_client/externals.c
> +++ branches/file-externals/subversion/libsvn_client/externals.c
> @@ -105,6 +109,10 @@ compare_external_items(svn_wc_external_i
> * Pass CANCEL_FUNC, CANCEL_BATON to svn_wc_remove_from_revision_control.
> *
> * Use POOL for all temporary allocation.
> + *
> + * This function is not passed a svn_wc_adm_access_t to ensure that
> + * what is being deleted is being opened separately so if there is a
> + * lock on it, it cannot be deleted.
> */
> static svn_error_t *
> relegate_dir_external(const char *path,
I had to read that paragraph a few times. Maybe something like this
instead?
"Note: this function is not passed a svn_wc_adm_access_t. Instead,
it separately opens the object being deleted, so that if there is a
lock on that object, the object cannot be deleted."
(Kudos in general on the thoroughness and clarity of your doc
maintenance on this branch, though.)
> --- branches/file-externals/subversion/libsvn_client/update.c Sun Aug 24 14:13:10 2008 (r32686)
> +++ branches/file-externals/subversion/libsvn_client/update.c Sun Aug 24 15:02:52 2008 (r32687)
> @@ -254,7 +254,8 @@ svn_client__update_internal(svn_revnum_t
> handling external items (and any errors therefrom) doesn't delay
> the primary operation. */
> if (SVN_DEPTH_IS_RECURSIVE(depth) && (! ignore_externals))
> - SVN_ERR(svn_client__handle_externals(traversal_info,
> + SVN_ERR(svn_client__handle_externals(adm_access,
> + traversal_info,
> entry->url,
> anchor,
> repos_root,
I think you've got your editor set to use TAB characters, causing the
above new line to look misindented under certain circumstances. (You
might want to check the rest of the branch for similar problems.)
-Karl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-08-27 20:42:54 CEST