[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] tests: cmdline: actual disk tree has wrong paths

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Tue, 26 Aug 2008 15:14:15 +0100

> Neels Hofmeyr wrote:
> > in the cmdline tests, after dumping "actual disk" trees to screen, it came
> > to my attention that all nodes below a depth of two have a wrong node.path.


Thanks for the fix! Committed revision 32723.

> > (It might make sense to altogether remove the root_node_name from PATH
> > strings in all of the different "actual" trees. But that's another issue.)

Yes, that sounds like it might be a good idea, but we'd have to find out
why that tag was added in the first place. There might be a good reason
for keeping it.

> > [[[
> > In the cmdline tests, fix PATH in "ACTUAL DISK" tree nodes, so that the
> > disk tree is printed correctly in the error output of a failing test.
> > "ACTUAL DISK" tree nodes only got a PATH string up to their respective
> > parents, breaking PATHs at a depth of more than 2; in side-effect, the
> > svntest.tree.root_node_name was missing from each PATH.
> > Also fix update_tests.py 1, which relied on the erratic PATH.
> >
> > * subversion/tests/cmdline/svntest/tree.py (handle_dir): Reverse the
> > order in which nodes are added to the tree, fixing PATH strings.
> >
> > * subversion/tests/cmdline/update_tests.py (detect_extra_files):
> > Strip the svntest.tree.root_node_name from nodes' PATH before
> > using it as a real file system path.
> >
> > Patch by: neels
> > ]]]

I tweaked your log message a bit, but nothing major.

Thanks again.
- Julian

To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-08-26 16:14:24 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.