Re: svn commit: r32545 - in trunk/subversion: libsvn_fs_base libsvn_fs_fs

On Tue, Aug 19, 2008 at 5:55 AM, <cmpilato_at_tigris.org> wrote:
>...
> +++ trunk/subversion/libsvn_fs_fs/tree.c Tue Aug 19 05:55:02 2008 (r32545)
> @@ -3077,9 +3077,14 @@ fs_node_origin_rev(svn_revnum_t *revisio
> {
> svn_pool_clear(subpool);
> SVN_ERR(svn_fs_fs__dag_get_node(&node, fs, pred_id, subpool));
> +
> + /* Why not just fetch the predecessor ID in PREDIDPOOL?
> + Because this function doesn't necessarily honor the
> + passed-in pool, and might return a value cached in the node
> + (which is allocated in SUBPOOL ... maybe). */

Why don't you fix the function to copy the ID if it gets yanked from
the cache? That will fix *all* uses of the function. Not just this
one.

Cheers,
-g

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-08-19 15:19:48 CEST