On Tue, Aug 12, 2008 at 01:48:56PM +0300, Daniel Shahaf wrote:
> Stefan Sperling wrote on Tue, 12 Aug 2008 at 12:33 +0200:
> > Glancing over the patch I could not see much else wrong with it
> > stylistically.
> >
>
> I did, a ^L character was moved around in libsvn_subr/io.c.
>
> > Someone will need to test it properly though before we can commit it.
> >
> > @everyone:
> > I might not have clearly stated this before, but I am +1 on the idea
> > of adding this functionality now. But only on the condition that we decide
> > to move out all platform-specific property handling into its own layer
> > in the future, as proposed by Julian. This code, and all the other special
> > props managing platform-specific features shall go into that layer
> > once it's ready. The client and working copy libraries should not get
> > littered with additional platform-specific code in the future.
> > It really does not belong there.
> >
>
> Could you(plural) explain how you see this working? Do we just move all
> the #ifdef's from libsvn_wc into a new library, or is there some greater
> abstraction being done here that I'm not seeing? What would libsvn_wc
> know about symlinks, according to the proposal?
Huh.
Well, obviously the details haven't been fleshed out yet.
Part of this effort would be coming up with a proper and sane
design, of course :)
As far as I'm concerned, it might well be tied to libsvn_wc.
Just in some manner that allows us to add more platform-specific
properties without fear that "Oh no! We're modifying core code!".
That is really what I think this idea is about. The notion that
adding more properties, which contain platform-specific data and
are managed from within Subversion, is bad, seems to call for some
sort of abstraction that gets rid of the problem.
I can't say more than this at the moment, I'm afraid.
So it's vapourware for now. Maybe defining it as a condition
on the appledouble patch being applied was a bit of a stretch.
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-08-12 13:11:12 CEST