Stefan Sperling wrote on Tue, 12 Aug 2008 at 12:33 +0200:
> Glancing over the patch I could not see much else wrong with it
> stylistically.
>
I did, a ^L character was moved around in libsvn_subr/io.c.
> Someone will need to test it properly though before we can commit it.
>
> @everyone:
> I might not have clearly stated this before, but I am +1 on the idea
> of adding this functionality now. But only on the condition that we decide
> to move out all platform-specific property handling into its own layer
> in the future, as proposed by Julian. This code, and all the other special
> props managing platform-specific features shall go into that layer
> once it's ready. The client and working copy libraries should not get
> littered with additional platform-specific code in the future.
> It really does not belong there.
>
Could you(plural) explain how you see this working? Do we just move all
the #ifdef's from libsvn_wc into a new library, or is there some greater
abstraction being done here that I'm not seeing? What would libsvn_wc
know about symlinks, according to the proposal?
Thanks,
Daniel
> I think we should open a "bite-sized" issue for factoring out
> platform-specific property handling into a layer of its own.
> Shall I do that?
>
> Stefan
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-08-12 12:49:19 CEST