Re: Doc string of prepare_subtree_ranges() [was: Merge deleting a file - compare its content]

On Fri, 2008-08-08 at 12:05 +0100, Julian Foad wrote:
> Paul Burba wrote:
> > Probably just stating the obvious, but keep in mind that
> > prepare_subtree_ranges() is a dedicated helper of
> > filter_merged_revisions() and almost all the arguments to the former
> > are straight from the latter. So understanding this function in a
> > vacuum is quite difficult.
>
> Yes, ack. Didn't mean to be too harsh. [...]

But then I continued...
[...]
> OK to an extent. But again, the reader does also need to know the common
> single definition of the output, otherwise he can't make use of the
> output without knowing which case it comes from.
[...]

Paul,

I've "gone off on one" about this particular function's doc string
because you drew it to my attention, but it may not be the best place to
spend energy now so don't feel you have to respond or do anything with
this.

Plenty of other stuff we need to do...

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-08-08 15:25:25 CEST