[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Set permissions on new fsfs shard dirs

From: Karl Fogel <kfogel_at_red-bean.com>
Date: Tue, 05 Aug 2008 13:05:45 -0400

Peter Samuelson <peter_at_p12n.org> writes:
>> When creating a new fsfs shard directory (revs/N, revprops/N), set its
>> permissions correctly.
>> * subversion/libsvn_fs_fs/fs_fs.c
>> (svn_fs_fs__hotcopy): Set permissions of a shard dir in revs/ and
>> revprops/ after creating it.
>> (commit_body): Ditto.
> r32355, and proposed for 1.5.2. I didn't create a test case, I don't
> know if that's important for something as small as this.

In an ideal world, we'd have test cases for every change.

In real life, yeah, I agree with your priorities -- this is not the sort
of change worth spending further hours of your time writing a test.

To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-08-05 19:06:04 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.