[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Doc strings for WC log file processing functions

From: Karl Fogel <kfogel_at_red-bean.com>
Date: Tue, 05 Aug 2008 13:02:30 -0400

Julian Foad <julianfoad_at_btopenworld.com> writes:
> On Tue, 2008-07-29 at 17:14 +0100, Julian Foad wrote:
>> While investigating Stefan Kung's crash, I found an opportunity to
>> improve documentation in libsvn_wc. Every little helps. Could anyone
>> read through and let me have any comments, especially on the three
>> places I marked "###", before I commit?
>> Log message and patch attached.
> Committed revision 32366, with only one "###" comment, the one noting
> that file_xfer_under_path()'s "special_only" parameter is ignored.

I looked into this a bit: r17495 is the "culprit".

It seems r17495 just meant to undo some of r17362. And r17362
apparently converted some inline code in file_xfer_under_copy() to call
svn_wc_translated_file2() instead, and used 'special_only' to decide
whether or not to pass SVN_WC_TRANSLATE_SPECIAL_ONLY flag to that
function. When SVN_WC_TRANSLATE_SPECIAL_ONLY got removed in r17495,
though, we didn't just revert to the old code in file_xfer_under_copy().

(Historical background: the special_only arg was added in r16645, and
the dependent code introduced with it seems to have remained
more-or-less in place until r17362.)

r17495 says:

   Review by: julianfoad
   Note: Doc string updates still under discussion with Julian;
         to be committed later.

Did this ever happen?


To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-08-05 19:02:47 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.